[CI] Cleanup dockerhub release action. #5748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Please do not merge it yet! We depend on this functionality for testing a new CI feature. Merging this without finishing our testing will break our infrastructure. I'll merge this as soon as the dependent task is done. |
Codecov Report
@@ Coverage Diff @@
## develop #5748 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1248 1248
Lines 100836 100836
========================================
Hits 70262 70262
Misses 30574 30574
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Remove temporary blocker of execution for the github action responsible to submit a PR to the homebrew repository, updating the CBMC version there. This was necessary during the testing of the dockerhub image push action, as we needed to test it live, and we didn't want to spam the homebrew repository with PRs pointing to testing/experimental PRs of ours.
`docker login` has a side effect of storing the credentials passed to it in the `.docker/config.json` which can be a security concern. This ameliorates the problem for us.
NlightNFotis
force-pushed
the
reverse_homebrew_removal
branch
from
83154e2 to
8577f7f
Compare
NlightNFotis
changed the title
|
Okay, this is now ready to be reviewed and merged. |
NlightNFotis
force-pushed
the
reverse_homebrew_removal
branch
from
8577f7f to
8bd1b69
Compare
Add instructions on how to run under docker in the release page draft text, and make some minor changes to the release action (change ubuntu version for one of the steps and change the version tag to contain just the version string).
NlightNFotis
force-pushed
the
reverse_homebrew_removal
branch
from
8bd1b69 to
f45b62c
Compare
piotr-grabalski
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last cleanup of the dockerhub image push action, and finalises this line of work by doing the following:
docker logoutinstruction to the action for better security of the credentials.