Move validate-goto-model before show-goto-functions #4389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
cristina-david,
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
smowton
force-pushed
the
smowton/cleanup/validate-model-before-show
branch
from
6f00335 to
eb8339a
Compare
|
@smowton |
tautschnig
approved these changes
Mar 14, 2019
Per a request in diffblue#4203 -- let's not surprise users by show-goto-functions producing output when the model has failed validation (if they want to view a broken model they can remove the validate parameter)
smowton
force-pushed
the
smowton/cleanup/validate-model-before-show
branch
from
eb8339a to
f940996
Compare
|
Cause was remove-returns treating actually bodyless stubs wrongly, but it no longer matters now remove-returns doesn't change types, so I just rebased this. |
peterschrammel
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #4203 -- if merged will render that redundant.