Split static field test into two parts #4203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised validate-goto-model and show-goto-functions can't be used together, as validation happens after the show operation.
Wouldn't it make sense to change that? |
|
I think no, it's good to be able to use |
|
But to do that you can run |
allredj
reviewed
Feb 15, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7bf082d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101130298
+1 to that: don't surprise the user. |
smowton
added a commit
to smowton/cbmc
that referenced
this pull request
Mar 14, 2019
Per a request in diffblue#4203 -- let's not surprise users by show-goto-functions producing output when the model has failed validation (if they want to view a broken model they can remove the validate parameter)
smowton
added a commit
to smowton/cbmc
that referenced
this pull request
Mar 14, 2019
Per a request in diffblue#4203 -- let's not surprise users by show-goto-functions producing output when the model has failed validation (if they want to view a broken model they can remove the validate parameter)
smowton
added a commit
to smowton/cbmc
that referenced
this pull request
Mar 15, 2019
Per a request in diffblue#4203 -- let's not surprise users by show-goto-functions producing output when the model has failed validation (if they want to view a broken model they can remove the validate parameter)
|
Moved validate-goto-model in #4389; therefore this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised validate-goto-model and show-goto-functions can't be used together, as validation happens after the show operation.