Update documentation for building cbmc on windows. #1504

andreast271 · 2017-10-21T06:58:02Z

Update makefiles to use reasonable default compiler for cygwin build.
Allow alternative downloader selection from make command line.

andreast271 · 2017-10-21T07:54:21Z

COMPILING


-   BUILD_ENV = MinGW
+   Open the Visual Studio Command prompt, and then start the Cygwin shell with


BUILD_ENV should be Cygwin, which will be detected correctly if BUILD_ENV = AUTO and make is called from the cygwin shell.

andreast271 · 2017-10-21T08:32:24Z

src/Makefile

-# minisat 2 download, for your convenience
+# minisat2 and glucose download, for your convenience
+
+DOWNLOADER = lwp-download



This enables the user to set an alternative download program without editing the Makefile.
E.g. to use wget on Windows under Cygwin, do
make DOWNLOADER=wget minisat2-download

andreast271 · 2017-10-21T08:32:59Z

src/common

@@ -101,17 +101,19 @@ else ifeq ($(BUILD_ENV_),Cygwin)
  CXXFLAGS ?= -Wall -O2
  CP_CFLAGS = -MMD -MP
  CP_CXXFLAGS += -MMD -MP -std=c++11 -U__STRICT_ANSI__
+  # Cygwin-g++ has problems with statically linking exception code.
+  # If linking fails, remove -static.
  LINKFLAGS = -static -std=c++11


For the static compilation problems, see Multiple definition error in static compilation with g++ under cygwin

andreast271 · 2017-10-21T08:33:44Z

src/common

 endif
 ifeq ($(origin CXX),default)
  #CXX    = g++
-  CXX = i686-w64-mingw32-g++
+  CXX = x86_64-w64-mingw32-g++
 endif


32 bit compilers (more precisely compilers where sizeof(size_t) == 4) will not work because of justified errors like this:

interpreter.cpp: In member function ‘size_t interpretert::get_size(const typet&): interpreter.cpp:971:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow] return 2ULL << 32ULL;

There's a suggestion to fix this: #987

kroening · 2017-10-23T14:59:38Z

It should also be mentioned that the CYGWIN build isn't recommended.

Among other reasons, you won't be able to do Unicode file names.

kroening · 2017-10-23T15:00:54Z

One more: I doubt that g++ 5.4 still works; I believe we need at least 5.8, if not higher.

kroening · 2017-10-23T15:04:07Z

Reading through the entire thing, I would recommend that we are more prescriptive. It's really hard to collect all the utilities (bison etc.) separately. Thus, I'd say "Get CYGWIN. Do this." I would scratch compilation with Cygwin, and only do MinGW and Visual Studio.

andreast271 · 2017-10-24T08:45:58Z

Is BUILD_ENV==MINGW in the Makefiles useful, or could it be removed?

tautschnig · 2017-10-24T08:47:55Z

Is BUILD_ENV==MINGW in the Makefiles useful, or could it be removed?

I believe there is a corporate customer that uses this set up.

Update makefiles to use reasonable default compiler for cygwin build. Allow alternative downloader selection from make command line.

andreast271 · 2017-10-24T12:21:23Z

src/util/config.cpp

@@ -862,7 +862,8 @@ bool configt::set(const cmdlinet &cmdline)
      #endif

      // MinGW has extra defines
-      ansi_c.defines.push_back("__int64=\"long long\"");
+      // defines are shell quoted, which gives the wrong result in this case
+      ansi_c.preprocessor_options.push_back("-D__int64=\"long long\"");
    }


This is a bug fix related to the PR, because it affects usability of the mingw build on windows. Due to shell quoting, using ansi_c.defines eventually produces code like this:

"long long" n;

Can that be split out into a separate PR? There should be a proper solution for this that works for other defines as well.

smowton

Looks sensible, but suggest tagging someone else that can try to reproduce these who has a Win32 box in the office!

andreast271 · 2017-10-24T12:55:10Z

I doubt that g++ 5.4 still works

It does still work.

739c7f5 Merge remote-tracking branch 'upstream/develop' into merge-develop-20171026 37b868a Merge pull request diffblue#251 from diffblue/feature/revert-recording-symbol-table 429c13f Merge pull request diffblue#1520 from smowton/smowton/fix/symbol_table_writer_erase d9f3a2f Revert "Disable OSX builds" 81bb39c Symbol-table writer: fix use of map key after erasure 021fe8f Merge pull request diffblue#1492 from tautschnig/perf-test 0729e3d Merge pull request diffblue#1517 from NathanJPhillips/bugfix/journaling-symbol-table-constructor 93ae9f3 Merge pull request diffblue#1527 from diffblue/revert-1510-always-inline c4ed1ae Revert security-scanner version of recording symbol table e83e307 Fixed scope of moved symbol 535f1df Revert "Fully process always_inline" 0096451 Replace broken copy constructor with move constructor a6adb19 Fix more catch std::string occurances 22a876f Merge pull request diffblue#1523 from reuk/reuk/update-compiling-instructions 8fe258b Update COMPILING with cmake setup instructions 99592b3 Merge pull request diffblue#1504 from andreast271/update-windows-build dff22b8 Make Windows compilation instructions more prescriptive bc3bc8f Merge pull request diffblue#1511 from tautschnig/fix-graphml 358829c Merge pull request diffblue#1510 from tautschnig/always-inline 3e77dd6 Merge pull request diffblue#1496 from smowton/smowton/feature/symbol_table_writer d115b4e catch by const ref instead of by value or non-const ref 444d824 Fix graphml output of concurrency witnesses 08c512d Make Windows compilation instructions more prescriptive bcf8ff3 Update documentation for building cbmc on windows. Update makefiles to use reasonable default compiler for cygwin build. Allow alternative downloader selection from make command line. 728dbb5 Merge pull request diffblue#1508 from smowton/smowton/1420-fragments/value_set_debugging 9d9e50d Merge pull request diffblue#1507 from smowton/smowton/1420-fragments/factor_java_object_init b2104b0 Merge pull request diffblue#1506 from smowton/smowton/1420-fragments/typecheck_expr_cleanup 7175efe Merge pull request diffblue#1505 from smowton/smowton/1420-fragments/invariants 7537302 Adding a java_lang_object_init function 86513ee Merge pull request diffblue#1324 from reuk/reuk/clang-format ea4a777 Merge pull request diffblue#1503 from reuk/reuk/rebuild-ansi-c-when-necessary d9c0598 [pointer-analysis] Better debugging information in pointer analysis 3146336 Remove unnecessary includes in java-typecheck 10b5c8e [java-bytecode/typecheck] Style: Changing assertions in preconditions 2afe377 Fully interpret __attribute__((always_inline)) 8eaf89e Apply symbol replacement in type_arg members 13a7553 Rebuild ansi-c library if non-source dependencies change b97a766 Merge pull request diffblue#1403 from karkhaz/kk-regenerate-arch-flags-binaries a4dc986 Merge pull request diffblue#1484 from diffblue/interpreter_size_t 9d4e0ca Merge pull request diffblue#1217 from KPouliasis/show_functions_dfs c3e6726 Script to automate performance evaluation of CBMC on AWS 912ee38 Improve symbol table style 6b1a49d Add missing goto-statistics file to Makefile d512204 Add cbmc and jbmc as install targets bc887c5 Merge commit '93e2d7626046f90e14de76abbaf16c57a0425d8a' into pull-support-20171019 c5c77ac Merge pull request diffblue#1495 from diffblue/codeowners2 f154d16 Merge pull request diffblue#1487 from martin-cs/goto-analyzer-6-part2 4955417 initialize_goto_model now returns a goto_model 56f924c Merge pull request diffblue#1483 from diffblue/signature_initialize_goto_model eef32db Methods for ai_baset to allow access to the ai_base_domaint for a location. aae984a Disable the regression test for now as it depends on the variable sensitivity domain. 3050c53 Don't stop when recursion found 93f2e1f Use is_bottom() to catch unreachable functions. 5b604ae Update the mock domain with the new ai_domain_baset interface. f9ca353 Add is_bottom() and is_top() to ai_domain_baset and derived domains. 88d8673 Rename the XML output to something a bit more meaningful. 2110cd1 Make formatting stage non-blocking on Travis a24ac3d Fixup compiling.md with more clang-format install instructions c3c24e2 Add symbol table writer 98643d7 initialize_goto_model now returns a goto_model fd6acc5 initial proposal for owners of code f39ae5c use mp_integer for addresses f6ae635 use std::size_t in interpreter 55e6594 Fixup cpplint.py 9d4b827 Update coding standard 8482b35 Add information about using clang-format 1dcc82c Convert COMPILING to markdown format 554cb54 Adjust cpplint to disable whitespace checks by default 6ce0dba Add travis style check f18979a Add clang-format config 622e2e3 Merge branch 'develop' into show_functions_dfs bea696a Regenerated cross-compiled arch flag test binaries 1fab1c1 Fixed show-call-sequences deature of goto instrument; added test suite git-subtree-dir: cbmc git-subtree-split: 739c7f5

andreast271 requested review from kroening, peterschrammel and tautschnig as code owners October 21, 2017 06:58

andreast271 commented Oct 21, 2017

View reviewed changes

andreast271 requested review from martin-cs, smowton and thk123 as code owners October 24, 2017 10:46

andreast271 added 2 commits October 24, 2017 12:25

Update documentation for building cbmc on windows.

bcf8ff3

Update makefiles to use reasonable default compiler for cygwin build. Allow alternative downloader selection from make command line.

Make Windows compilation instructions more prescriptive

08c512d

andreast271 force-pushed the update-windows-build branch from 29c6484 to 08c512d Compare October 24, 2017 11:33

andreast271 commented Oct 24, 2017

View reviewed changes

smowton approved these changes Oct 24, 2017

View reviewed changes

andreast271 closed this Oct 24, 2017

andreast271 reopened this Oct 24, 2017

Make Windows compilation instructions more prescriptive

dff22b8

andreast271 force-pushed the update-windows-build branch from 26bc44b to dff22b8 Compare October 24, 2017 16:10

kroening merged commit 99592b3 into diffblue:develop Oct 24, 2017

andreast271 deleted the update-windows-build branch March 21, 2021 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update documentation for building cbmc on windows. #1504

Update documentation for building cbmc on windows. #1504

Uh oh!

andreast271 commented Oct 21, 2017

Uh oh!

andreast271 Oct 21, 2017 •

edited

Loading

Uh oh!

andreast271 Oct 21, 2017

Uh oh!

andreast271 Oct 21, 2017

Uh oh!

andreast271 Oct 21, 2017 •

edited

Loading

Uh oh!

peterschrammel Oct 23, 2017

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

andreast271 commented Oct 24, 2017

Uh oh!

tautschnig commented Oct 24, 2017

Uh oh!

andreast271 Oct 24, 2017

Uh oh!

kroening Oct 24, 2017

Uh oh!

smowton left a comment

Uh oh!

andreast271 commented Oct 24, 2017

Uh oh!

Uh oh!


		BUILD_ENV = MinGW
		Open the Visual Studio Command prompt, and then start the Cygwin shell with

Update documentation for building cbmc on windows. #1504

Update documentation for building cbmc on windows. #1504

Uh oh!

Conversation

andreast271 commented Oct 21, 2017

Uh oh!

andreast271 Oct 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreast271 Oct 21, 2017

Choose a reason for hiding this comment

Uh oh!

andreast271 Oct 21, 2017

Choose a reason for hiding this comment

Uh oh!

andreast271 Oct 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterschrammel Oct 23, 2017

Choose a reason for hiding this comment

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

kroening commented Oct 23, 2017

Uh oh!

andreast271 commented Oct 24, 2017

Uh oh!

tautschnig commented Oct 24, 2017

Uh oh!

andreast271 Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

kroening Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

smowton left a comment

Choose a reason for hiding this comment

Uh oh!

andreast271 commented Oct 24, 2017

Uh oh!

Uh oh!

andreast271 Oct 21, 2017 •

edited

Loading

andreast271 Oct 21, 2017 •

edited

Loading