This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Update dependencies #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Laravel 8 and change Typesense PHP library to be the new official name
…stead of getTable()
Contributor
|
Hi @manavo, Thank a lot for your time and efforts working on enhancing this client, it's highly appreciated. Should I merge this PR now or are you planning on updating other things? please advice. Cheers |
Contributor
Author
|
I’ve already piled in more than I was planning, so maybe worth merging this and if I find anything else I can make a new PR 🙂 |
AbdullahFaqeir
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Laravel 8 and change to use the new namespace of the Typesense PHP library.
Also removed the catching and silently ignoring of exceptions, so this also closes #3.
I've also made a change to use the model's
searchableAsmethod as defined by Scout, to define what the name of the index should be.