Skip to content
This repository was archived by the owner on Dec 12, 2021. It is now read-only.
This repository was archived by the owner on Dec 12, 2021. It is now read-only.

Consider allowing all exceptions to bubble up #3

@aaronredwood

Description

@aaronredwood

public function flush($model): void

In regards to the Issue I reported in typesense-php, it took me a lot longer to discover the problem in scout:import because of trapping the exceptions in this method. Please consider either allowing the exceptions to bubble up, or use Logging to report them. I ultimately wrapped the block in a catch-all, and threw a new Exception, referencing the class of the old one and reporting the ID # of the model that the exception occurred on.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions