Skip to content

CE-572 Retry bucket creation if failed #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2023
Merged

CE-572 Retry bucket creation if failed #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 38 additions & 12 deletions src/controller/couchbase_lib/_bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,20 @@ def bucket_remove(self, bucket_name):
helper_lib.sleepForSecond(2)

def bucket_create(
self, bucket_name, ram_size, bucket_type, bucket_compression
self,
bucket_name,
ram_size,
bucket_type,
bucket_compression,
retry: bool = True,
):
logger.debug("Creating bucket: {} ".format(bucket_name))
logger.debug(f"Creating bucket: {bucket_name} ")
# To create the bucket with given ram size
self.__validate_bucket_name(bucket_name)
if ram_size is None:
logger.debug(
"Needed ramsize for bucket_create. Currently it is: {}".format(
ram_size
)
"Needed ramsize for bucket_create. "
f"Currently it is: {ram_size}"
)
return

Expand All @@ -132,9 +136,7 @@ def bucket_create(
bucket_type = "couchbase"

if bucket_compression is not None:
bucket_compression = "--compression-mode {}".format(
bucket_compression
)
bucket_compression = f"--compression-mode {bucket_compression}"
else:
bucket_compression = ""

Expand All @@ -150,18 +152,42 @@ def bucket_create(
evictionpolicy=policy,
bucket_type=bucket_type,
bucket_compression=bucket_compression,
**env
**env,
)
logger.debug("create bucket {}".format(command))
logger.debug(f"create bucket {command} for {bucket_name}")
kwargs[ENV_VAR_KEY].update(env_vars)
output, error, exit_code = utilities.execute_expect(
self.connection, command, **kwargs
)
logger.debug(
"create bucket output: {} {} {}".format(output, error, exit_code)
f"create bucket output for {bucket_name}: "
f"{output} {error} {exit_code}"
)
helper_lib.sleepForSecond(2)

bucket_list = self.bucket_list()
bucket_name_list = [item["name"] for item in bucket_list]
if bucket_name not in bucket_name_list and retry:
self.bucket_create(
bucket_name=bucket_name,
ram_size=ram_size,
bucket_type=bucket_type,
bucket_compression=bucket_compression,
retry=False,
)
logger.debug(
f"Bucket creation failed for {bucket_name} "
"on the first attempt, retrying."
)
elif bucket_name not in bucket_name_list:
error_message = f"Bucket creation failed for {bucket_name}" + (
", even after retry." if not retry else "."
)
logger.error(error_message)
raise BucketOperationError(error_message)

logger.debug(f"Bucket creation successful for {bucket_name}.")

def bucket_list(self, return_type=list):
# See the all bucket.
# It will return also other information like ramused, ramsize etc
Expand Down Expand Up @@ -249,7 +275,7 @@ def monitor_bucket(self, bucket_name, staging_UUID):
source_port=self.source_config.couchbase_src_port,
bucket_name=bucket_name,
uuid=staging_UUID,
**env
**env,
)
kwargs[ENV_VAR_KEY].update(env_vars)
stdout, stderr, exit_code = utilities.execute_expect(
Expand Down