CE-572 Retry bucket creation if failed #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishk1536
force-pushed
the
dlpx/pr/satishk1536/c7ade8b0-989e-4b64-aba0-96e1fcd79046
branch
from
083f5e8 to
873c457
Compare
satishk1536
requested review from
ankurtyagi-sdk,
manaskhandeshe-delphix and
prasad-in
satishk1536
force-pushed
the
dlpx/pr/satishk1536/c7ade8b0-989e-4b64-aba0-96e1fcd79046
branch
from
873c457 to
4a2048d
Compare
satishk1536
force-pushed
the
dlpx/pr/satishk1536/c7ade8b0-989e-4b64-aba0-96e1fcd79046
branch
from
4a2048d to
d38450f
Compare
ayesharustgi-delphix
approved these changes
Oct 26, 2023
prasad-in
approved these changes
Oct 26, 2023
manaskhandeshe-delphix
approved these changes
Oct 26, 2023
satishk1536
deleted the
dlpx/pr/satishk1536/c7ade8b0-989e-4b64-aba0-96e1fcd79046
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When executing the command to create a bucket, there is no direct error code or indication provided by the command that allows the code to determine whether the bucket creation was successful or not. This lack of error code or status information makes it challenging to reliably identify whether the bucket was created as intended.
Solution
The solution is to check the existence of the newly created bucket in the list of buckets after the creation command is executed. If the bucket is not found, a retry is attempted, and if the retry also fails, an error is logged.
Testing Done
Unit test is Done.