remove dependency on old mock external module #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Greetings @a-detiste, nice to hear from you again! I think I'm good with the mock changes but we've definitely had some problems with the removal of the absolute_import imports from future. Those issues are referenced on #1184 and discussed in more detail in PYTHON-1348. So for the moment would you mind removing the absolute_import removals and just leaving the rest of the changes in this PR? I think that change could go in pretty quickly. |
|
Hi, let's try again this trimmed down PR. The |
absurdfarce
approved these changes
May 30, 2024
|
Thanks for this one @a-detiste! |
dkropachev
pushed a commit
to dkropachev/python-driver
that referenced
this pull request
Mar 5, 2025
dkropachev
pushed a commit
to dkropachev/python-driver
that referenced
this pull request
Mar 5, 2025
dkropachev
pushed a commit
to dkropachev/python-driver
that referenced
this pull request
Mar 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
After the
sixremoval, here's more Python2-era removal.https://github.com/testing-cabal/mock
mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.