Remove backup(.bak) files and PY2 __future__ imports #1184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoening
changed the title
bschoening
changed the title
|
Hey, thanks for the PR @bschoening! I'm quite good with the removal of the backup files but unless I'm missing something the future imports removed here were the same ones we had a problem with in a previous PR. Those changes were eventually reverted in the run-up to 3.28.0. There was some follow-up conversation around the (very unexpected) issues that were introduced by removing this code... but I can't find it right away. |
|
PYTHON-1348 is what I was thinking of |
|
@absurdfarce ah, ok. It's ok to cherry pick just the .bak file deletes then, and we can deal with future separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear to be accidentally checked in and should be removed.