PYTHON-1378 Expand search directories for includes #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when we're dealing with OS X 2. Add include/lib directories used by CentOS in order to (hopefully) build libev extension when building wheels
|
Note that this will also require the merge of a fix on the datastax/python-driver-wheels side as well in order to leverage these changes. |
absurdfarce
commented
Feb 28, 2024
|
|
||
| libev_includes = ['/usr/include/libev', '/usr/local/include', '/opt/local/include', '/usr/include'] | ||
| if is_macos: | ||
| libev_includes.extend(['/opt/homebrew/include', os.path.expanduser('~/homebrew/include')]) |
There was a problem hiding this comment.
Just making the recent changes to support builds using Homebrew constrained to OSX builds only
fruch
added a commit
to fruch/python-driver
that referenced
this pull request
Jun 6, 2024
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (datastax#1199) PYTHON-1378 Expand search directories for includes (datastax#1198) clean up last "import six" (datastax#1197) fix build from source on macos using homebrew (datastax#1196) Added 3.29.0 to docs.yaml
fruch
added a commit
to fruch/python-driver
that referenced
this pull request
Jun 6, 2024
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (datastax#1199) PYTHON-1378 Expand search directories for includes (datastax#1198) clean up last "import six" (datastax#1197) fix build from source on macos using homebrew (datastax#1196) Added 3.29.0 to docs.yaml
dkropachev
pushed a commit
to dkropachev/python-driver
that referenced
this pull request
Mar 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure we can find include directories for packages installed on the Docker images used by cibuildwheel