fix build from source on macos using homebrew #1196
Conversation
Signed-off-by: Yago Riveiro <[email protected]>
|
Thanks for the PR @yriveiro ! Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks! |
|
FTR PYTHON-1376 has been closed as a duplicate of PYTHON-1378. That effort focuses on getting the wheel build fixed, however, while @yriveiro 's fix in this PR facilitates building the extension correctly on OS X + Homebrew. Since it's addressing a slightly different problem than what's discussed in PYTHON-1378 I'd like to keep this PR open and handle it just like any other PR; it seems like a worthwhile improvement to consider. |
I think I had done time ago but I reset it and signed again. |
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (datastax#1199) PYTHON-1378 Expand search directories for includes (datastax#1198) clean up last "import six" (datastax#1197) fix build from source on macos using homebrew (datastax#1196) Added 3.29.0 to docs.yaml
…sync_with_upstream_3.29.1 version 3.29.1 * tag '3.29.1' of https://github.com/datastax/python-driver: Release 3.29.1: changelog & version (datastax#1199) PYTHON-1378 Expand search directories for includes (datastax#1198) clean up last "import six" (datastax#1197) fix build from source on macos using homebrew (datastax#1196) Added 3.29.0 to docs.yaml
Documentation here mentions to install
libevfrom homebrew.The problem I found is that the pre-build package from pip doesn't have the extensions compiled PYTHON-1376. Building from source on macOS doesn't find
libevinclude folder for Homebrew as well.This PR fixes the missing include folder to be aligned with the current documentation.