Issue/230 Org OrgAff Update Performance #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case checks whether an entry is deleted from the read_access table for a resource configured for role access by a DIC member (member.com) of the parent organization (parent.com) if the OrganizationAffiliation for that parent/member relationship changes from DIC to HRP.
Added performance test for Organization and OrganizationAffiliation updates with 500.000 rows existing in the tasks table.
Added a new all_read_access_resources view that includes all resources except Task and QuestionnaireResponse. Improved after organizations and organization_affiliations insert triggers by removing unnecessary delete/insert operations for FHIR updates (db inserts) of unchanged Organization and OrganizationAffiliation resources. Unchanged in this case means no active status change for both resource types and no role change for OrganizationAffiliations. Both triggers now also use the new all_read_access_resources view.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dsf-fhir/dsf-fhir-server/src/test/java/dev/dsf/fhir/dao/OrganizationAffiliationDaoTest.java
Fixed
Show fixed
Hide fixed
dsf-fhir/dsf-fhir-server/src/test/java/dev/dsf/fhir/dao/OrganizationAffiliationDaoTest.java
Fixed
Show fixed
Hide fixed
dsf-fhir/dsf-fhir-server/src/test/java/dev/dsf/fhir/dao/OrganizationDaoTest.java
Fixed
Show fixed
Hide fixed
dsf-fhir/dsf-fhir-server/src/test/java/dev/dsf/fhir/dao/OrganizationDaoTest.java
Fixed
Show fixed
Hide fixed
wetret
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrganizationAffiliationrole update test case.OrganizationandOrganizationAffiliationupdate test cases for database pre filled with 500_000 rows intaskstable.all_read_access_resourcesview that contains all resources exceptTaskandQuestionnaireResponseas read access to both is not configured via meta read-access tags.AFTER INSERT ON organizationsandAFTER INSERT ON organization_affiliationstrigger.closes #230