-
-
Notifications
You must be signed in to change notification settings - Fork 740
Prevent Task stream dashboard showing date #9109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Opened #9110 to track unrelated CI failures here |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 5h 22m 6s ⏱️ - 3m 56s For more details on these failures, see this check. Results for commit 331e137. ± Comparison against base commit 7024d52. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mindeps seems to be passing so that suggests older versions are working ok.
When it shows the timedelta what is it a delta from? From when the scheduler started, when the dashboard was opened, or something else?
If it's from scheduler start then that makes a lot of sense to me.
To be honest, I don't know. I've add negative start times if submitting tasks before the Scheduler has really started. But if I wait, it always starts tasks at 0. I try to investigate through TaskStreamPlugin, but I'm really not sure of the logic. |
Just to be sure, I tried with Bokeh 3.7.0, and I've got an error when opening the Dashboard:
So probably not a so simple change if we want some bokeh backward compatibility... |
We could just add a runtime check on the bokeh version, on older versions we just leave the date bug in and use |
Yes that would make sense, I was not sure if this was already something that was done somewhere. So just something like x_axis_type="timedelta" if bokeh.__version__ >= 3.8 else "datetime" |
Yeah exactly. We do this in other places to handle bokeh backward compatibility. E.g distributed/distributed/dashboard/core.py Lines 29 to 36 in 9308cd8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guillaumeeb.
I tried it out locally and it looks good. Pushed some quick linting fixes.
Happy to merge pending CI
How, thanks @jacobtomlinson, I was looking at those linting problems but you beat me to it! Just a quick summary: I tested this with bokek 3.4, dashboard looks like this: So I guess with some up to date Bokeh version, the displayed information will be less misleading! |
Yeah I think all of this is an improvement over the original screenshot from #9055 ![]() |
Closes #9055
pre-commit run --all-files
At first, I tried to configure Bokeh

DatetimeTickFormatter
to avoid showing context. I guess this looks the same than task stream a few months ago:From what I could tell, there already was this
01/01
legend, which annoyed me.Then I became aware of the
timedelta
formatter, which in the end is what Task stream information is showing, so just switching to this:I feel the second solution is better.
Some considerations:
timedelta
x_axis_type was only integrated in Bokeh 3.8 last version... Not sure how it should be handled.