Support --source in FrontendServerClient
#1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Oct 18, 2022
jakemac53
reviewed
Oct 18, 2022
|
@jakemac53 I don't believe my changes should have impacted any tests, because no codes invoke the API yet. Are the tests on this repo flaky? |
jakemac53
approved these changes
Oct 19, 2022
|
I think they are flaky yes (in particular the integration tests that use dwds etc). Trying just re-running them... |
|
Thanks @jakemac53! Now it's all green, merged. Next step is to publish this version so I can depend on it in |
|
Sounds good, I am not sure if this is auto-rolled or not, cc @devoncarew might know? |
|
It's rolling in now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart-review.googlesource.com/c/sdk/+/231334 introduced passing additional sources to
gen_kernel.This PR exposes this option in the
FrontendServerClientso that it can be invoked from pub/dartdev which uses this API.