Fix starting the daemon client on Windows #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
changed the title
kevmoo
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a
pub.batprocess with modeProcessStartMode.detachedWithStdiothe corresponding process will start a detached window (regardless of therunInShelloption) that does not forward STDIO. The daemon client expects ready signals on STDIO and thus must work around this limitation by starting the pub snapshot directly.This work around is still somewhat clunky on Windows. The daemon process spawns multiple persistent workers that create a blank cmd window. If these windows are closed they will reopen upon build. Further windows will not open if one already exists. Even with this oddity I believe this is a preferable alternative to dart-lang/build#2009.
I'll need to investigate further but the root cause of this oddity is likely within pub or the SDK.
This is a workaround for dart-lang/sdk#35809
Closes #102