Skip to content

Fix daemon client issues on Windows #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix daemon client issues on Windows #2009

wants to merge 1 commit into from

Conversation

grouma
Copy link
Member

@grouma grouma commented Jan 30, 2019

Workaround for dart-lang/sdk#35809

  • Route communication through a shared file instead of STDIO
  • Provide shared utilities for this communication
  • Update package:build_runner to depend on the latest package:build_daemon and make use of new shared utilities

@grouma grouma requested a review from jakemac53 January 30, 2019 21:48
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jan 30, 2019
@grouma grouma closed this Jan 31, 2019
@grouma grouma deleted the window-fixes branch January 31, 2019 01:30
@grouma grouma mentioned this pull request Jan 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @googlebot