[out of date] Analyzer ready for Dart 2.0

[devoncarew]

This is a meta issue for tracking getting the analyzer ready for Dart 2.0.

Dart 2.0 support in the current front end:

• Support 2.0 in the analyzer independent of the new front end Support 2.0 in the analyzer independent of the new front end #31640 [meta]

Analyzer integrated with the new front end:

• Scanner integration
• Parser integration
  • parser completeness measured by a script
  • build AST with FE's parser [status: ast_builder w/ error recovery in progress]
  • Full coverage of parser error messages in FE
    • Every message produced by analyzer's parser should also be produced by FE's parser
  • Error recovery [status: in progress]
    • all error recovery scenarios modeled in analyzer's parser also handled by FE's parser
    • run all analyzer, analysis server (including code-completion), and dartfmt tests
• Error integration
  • spec errors copied from the FE; lints and hints from the analyzer
  • previously calculated errors are available to analyzer
• Element model and type-system integration
  • Synthesize element-model from kernel outline files
    • Implement synthesis for non-erroneous input
    • Implement synthesis for erroneous input: this requires kernel-format changes to represent erroneous code
  • Full coverage of type-system error messages
    • Every type-system error detected by analyzer's type checker are covered by FE's type-checker as well
  • Analyzer uses FE’s local type-inference information inside method bodies
• Compile time constants
  • evaluation of compile-time constants
• Benchmarking
  • analysis server benchmarks support the --preview-dart-2 flag
  • fix exceptions when running the benchmark with --preview-dart-2 exception when running the analysis server benchmarks with --preview-dart-2 #31554
  • add benchmarks.dart run --preview-dart-2 ... to tools/bots/try_benchmarks.sh
  • add a new target analysis server to our performance benchmarking system
• Analysis server integration tests
  • tests converted over to run both with and without --preview-dart-2
  • test failures addressed Analysis server integration test failures with --use-cfe #31571 [meta]
• Command line analyzer (dartanalyzer supports --preview-dart-2)
  • --preview-dart-2 flag added
  • dartanalyzer tests duplicated to run both with and without --preview-dart-2
  • preview-dart-2 tests triaged and failures addressed tracking issue for dartanalyzer CLI test failures with --use-cfe #31655
  • determine whether dartanalyzer build mode requires porting to --preview-dart-2
    • port dartanalyzer build mode to work with --preview-dart-2
• Kythe support ready for Dart 2.0 Migrate Kythe support to the new analyzer API #31645 [meta]

[devoncarew]

@jwren, is there known work or investigation to ensure that our kythe support continues to work after the new FE integration? If so, can you create a meta issue to track that work and link it back to here?

[jwren]

Created #31645

[devoncarew]

@bwilkerson @sigmundch re: evaluation of compile-time constants above - just confirming that we currently expect that this will need to be re-implemented in analyzer?

[devoncarew]

@scheglov @MichaelRFairhurst can you vet the Error integration section items above? If those look good, we could link to issues for each item.

[devoncarew]

@danrubel can you review the Parser integration section?

[danrubel]

Parser integration section LGTM

[sigmundch]

re: compile-time constants, yes, that's my understanding too. Dart2js had to do it too.

[devoncarew]

I'm going to re-purpose this for the new AnalyzerCFE milestone, and likely break it out into new issues.