feat: Add --ignore-warnings flag to pub publish --dry-run #4698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
commented
Oct 31, 2025
szakarias
approved these changes
Oct 31, 2025
| @@ -0,0 +1,67 @@ | |||
| // Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file | |
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file |
lib/src/command/lish.dart
Outdated
| valueHelp: 'dir', | ||
| ); | ||
| argParser.addFlag( | ||
| 'fatal-warnings', |
There was a problem hiding this comment.
Nit: I somehow feel that this name is not the best... Maybe 'ignore-warnings' or something along that path?? Not sure...
There was a problem hiding this comment.
Yeah - that's better - less negation...
sigurdm
changed the title
publish --dry-run --no-fatal-warnings
sigurdm
force-pushed
the
feature/fatal-warnings
branch
from
c8b57cf to
47c5a83
Compare
sigurdm
force-pushed
the
feature/fatal-warnings
branch
from
47c5a83 to
a0f6384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4696