Update goldens

Author: sigurdm

lib/src/command/lish.dart

@@ -125,10 +125,12 @@ class LishCommand extends PubCommand {
       valueHelp: 'dir',
     );
     argParser.addFlag(
-      'fatal-warnings',
-      help: 'When disabled, exit 0 even if there are warnings in --dry-run',
-      defaultsTo: true,
+      'ignore-warnings',
+      help: 'Do not treat warnings as fatal.',
+      negatable: false,
+      defaultsTo: false,
     );
+
   }
 
   Future<void> _publishUsingClient(
@@ -305,11 +307,10 @@ the \$PUB_HOSTED_URL environment variable.''');
       usageException('Cannot use both --to-archive and --force.');
     }
 
-    if (argResults.wasParsed('fatal-warnings') && !dryRun) {
-      usageException(
-        '`--no-fatal-warnings` can only be used with `--dry-run`.',
-      );
+    if (argResults.wasParsed('ignore-warnings') && !dryRun) {
+      usageException('`--ignore-warnings` can only be used with `--dry-run`.');
     }
+
   }
 
   Future<_Publication> _publicationFromEntrypoint() async {
@@ -501,7 +502,8 @@ the \$PUB_HOSTED_URL environment variable.''');
             : _publicationFromArchive(_fromArchive));
     if (dryRun) {
       log.message(publication.warningsCountMessage);
-      if (publication.warningCount != 0 && argResults.flag('fatal-warnings')) {
+      if (publication.warningCount != 0 &&
+          !argResults.flag('ignore-warnings')) {
         overrideExitCode(DATA);
       }
       return;

test/lish/fatal_warnings_test.dart renamed to test/lish/ignore_warnings_test.dart

@@ -27,7 +27,7 @@ void main() {
   });
 
   test(
-    'dry-run with --no-fatal-warnings and warnings exits with SUCCESS',
+    'dry-run with --ignore-warnings and warnings exits with SUCCESS',
     () async {
       (await servePackages()).serve('foo', '1.0.0');
       await d
@@ -39,14 +39,14 @@ void main() {
           .create();
 
       await runPub(
-        args: ['publish', '--dry-run', '--no-fatal-warnings'],
+        args: ['publish', '--dry-run', '--ignore-warnings'],
         output: contains('Package has 1 warning.'),
         exitCode: exit_codes.SUCCESS,
       );
     },
   );
 
-  test('--no-fatal-warnings without --dry-run is a usage error', () async {
+  test('--ignore-warnings without --dry-run is a usage error', () async {
     (await servePackages()).serve('foo', '1.0.0');
     await d
         .validPackage(
@@ -57,9 +57,9 @@ void main() {
         .create();
 
     await runPub(
-      args: ['publish', '--no-fatal-warnings'],
+      args: ['publish', '--ignore-warnings'],
       error: contains(
-        '`--no-fatal-warnings` can only be used with `--dry-run`.',
+        '`--ignore-warnings` can only be used with `--dry-run`.',
       ),
       exitCode: exit_codes.USAGE,
     );

test/testdata/goldens/help_test/pub publish --help.txt

@@ -10,7 +10,7 @@ Usage: pub publish [options]
 -f, --force                  Publish without confirmation if there are no errors.
     --skip-validation        Publish without validation and resolution (this will ignore errors).
 -C, --directory=<dir>        Run this in the directory <dir>.
-    --[no-]fatal-warnings    Treat warnings as fatal.
+    --[no-]fatal-warnings    When disabled, exit 0 even if there are warnings in --dry-run
                              (defaults to on)
 
 Run "pub help" to see global options.