Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Oct 1, 2025

Fixes #371


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.11.0 0.12.1-wip 0.11.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/firehose/lib/src/health/health.dart 💔 94 % ⬇️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@mosuem mosuem requested review from natebosch and removed request for devoncarew October 1, 2025 10:54
@mosuem mosuem merged commit 0d7ffaa into main Oct 2, 2025
14 checks passed
@mosuem mosuem deleted the renameSingleComments branch October 2, 2025 08:45
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 6, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/669b15f..ec2a4fe):
  ec2a4fee  2025-10-06  dependabot[bot]  Bump test_reflective_loader from 0.2.3 to 0.4.0 (dart-lang/dartdoc#4111)
  2ec3e4ef  2025-10-02  Konstantin Scheglov  Stop using TypeDefiningElement. (dart-lang/dartdoc#4112)
  f65c7e21  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/dartdoc#4113)

ecosystem (https://github.com/dart-lang/ecosystem/compare/36e514d..96ee861):
  96ee861  2025-10-02  Devon Carew  misc repo metadata updates (dart-lang/ecosystem#372)
  0d7ffaa  2025-10-02  Moritz  Rename comments (dart-lang/ecosystem#373)
  a3cf960  2025-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#374)

test (https://github.com/dart-lang/test/compare/a16f149..8083c8f):
  8083c8f2  2025-10-03  Nate Bosch  Make all package:coverage imports conditional (dart-lang/test#2544)

tools (https://github.com/dart-lang/tools/compare/ce9d2ad..6866f9b):
  6866f9b1  2025-10-06  Morgan :)  Allow more time for tests on Windows. (dart-lang/tools#2193)
  1264445e  2025-10-06  Morgan :)  Fix flaky test on Windows. (dart-lang/tools#2192)

webdev (https://github.com/dart-lang/webdev/compare/0b2a408..29ba1b1):
  29ba1b12  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/webdev#2693)

Change-Id: I9582b0380b2b974a2d05ab4f77c67c14e92aaa63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453580
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:firehose type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Health workflow comment concatenation is broken

3 participants