Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/health_base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ jobs:
--experiments ${{ inputs.experiments }} \
--health_yaml_name ${{ inputs.health_yaml_name }}

- run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
- run: test -f current_repo/output/comment-${{ inputs.check }}.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment-${{ inputs.check }}.md
if: ${{ '$action_state' == 1 }}

- name: Upload coverage to Coveralls
Expand All @@ -214,4 +214,4 @@ jobs:
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: comment-${{ inputs.check }}
path: current_repo/output/comment.md
path: current_repo/output/comment-${{ inputs.check }}.md
1 change: 1 addition & 0 deletions pkgs/firehose/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Make the PR health output less verbose by collapsing warnings by default.
- Bump dart_apitool to fix errors with equal types being reported as different.
- Give comment files in health work.

## 0.12.0

Expand Down
2 changes: 1 addition & 1 deletion pkgs/firehose/lib/src/health/health.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Health {
path.join(
directory.path,
'output',
'comment.md',
'comment-${check.displayName}.md',
) {
flutterExecutable =
(Process.runSync('which', ['-a', 'flutter']).stdout as String)
Expand Down