use the new Resource api #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devoncarew
commented
Aug 7, 2015
devoncarew
commented
- redux of switch to the new Resources api #769 - keep the old resource loading as a backup, until pub global activate generates .packages files
- use the new Resource API
- only support SDK 1.12.0 and newer
| Uint8List bytes = await _doLoad(path); | ||
| return new String.fromCharCodes(bytes); | ||
| return new Resource(path).readAsString().catchError((_) async { | ||
| var bytes = await _doLoad(path); |
There was a problem hiding this comment.
maybe a note that we can remove this when a certain issue is closed?
|
Thanks for doing this! lgtm but can you add a note saying when we can delete the catchError bits? |
|
We need to disable the windows build until 1.12 is available on chocolatey (or scoop). |
add tracking issue for resource loading
devoncarew
force-pushed
the
ddc_resource_api
branch
from
dae087b to
38be28f
Compare
|
and, squashed |
|
Yay! This is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.