switch to the new Resources api #769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /// Determine how to do the load. HTTP? Snapshotted? From source? | ||
| Future<Uint8List> _doLoad(final String path) { |
There was a problem hiding this comment.
this will break on pub global activated installs, because those don't write .packages yet. We might not want to remove all this code quite yet.
There was a problem hiding this comment.
Hmm, so try the new resource api, and if that fails, fall back to the pub_cache method?
There was a problem hiding this comment.
For now, yes. Just test this with pub global activate before you commit.
(you can globally activate without pushing to pub, fwiw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder until 0.12.0-dev5 is out.