Merge from head into the nnbd branch once more #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Just try to get something working * simplify * Store the current date in output * well it doesn't complain locally now? * Empty commit to trigger CI
* Enforce strict-raw-types * presubmit Co-authored-by: Janice Collins <[email protected]>
* Allow magical accessors from nowhere if they are Enum related * intermediate * dartfmt * Add a stub Enum class since that's now in the required list
srawlins
approved these changes
Sep 28, 2021
|
|
||
| /// Calls [valueAt] with the working directory at the start of the program. | ||
| T? valueAtCurrent() => valueAt(_directoryCurrent); | ||
| // TODO(jcollins-g): use of dynamic. https://github.com/dart-lang/dartdoc/issues/2814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the non-"verified" bits here. I tried to minimize those changes as this is just trying to be a merge.
Change return type on valueAt to dynamic, and expand
getValueAsto call valueAt too to save some casting. Filed #2814 asDartdocOptionswas designed when "strong mode" was still a new thing and we could do better now with the new language features.There's a cleanup we could do to use
getValueAsmore extensively, might be something we could do to help mitigate #2814.