Skip to content

Reduce broad imports of dartdoc.dart #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Conversation

srawlins
Copy link
Member

This also involves moving DartdocFailure to its own file.

The idea here is that dartdoc.dart exports everything, so we really want to minimize imports of that library within the package. This should help with the null safety migration, because it simplifies the import graph, and in particular reduces cycles.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Sep 22, 2021
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes, a hundred times yes

@srawlins srawlins merged commit b1b9ee8 into dart-lang:master Sep 22, 2021
@srawlins srawlins deleted the move-failure branch September 22, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants