Skip to content

Remove our copy of format_coverage; coverage 0.12.4 includes the fix #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2019
Merged

Remove our copy of format_coverage; coverage 0.12.4 includes the fix #1903

merged 1 commit into from
Jan 14, 2019

Conversation

jcollins-g
Copy link
Contributor

An internal cleanup; with coverage landing dart-archive/coverage#240, we don't need our own copy anymore.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 11, 2019
@jcollins-g jcollins-g requested a review from pq January 11, 2019 22:09
pq
pq approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.808% when pulling e3f3eed on coverage-update into ca6a56d on master.

@jcollins-g jcollins-g merged commit 0a12e77 into master Jan 14, 2019
@jcollins-g jcollins-g deleted the coverage-update branch January 14, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcollins-g @coveralls @pq @googlebot