Skip to content

Remove our copy of format_coverage; coverage 0.12.4 includes the fix #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Remove our copy of format_coverage; coverage 0.12.4 includes the fix #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ dev_dependencies:
build: ^1.0.1
build_runner: ^1.0.0
build_version: ^1.0.0
coverage: any
coverage: ^0.12.4
dhttpd: ^3.0.0
glob: ^1.1.5
grinder: ^0.8.2
Expand Down
5 changes: 3 additions & 2 deletions test/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,9 @@ class CoverageSubprocessLauncher extends SubprocessLauncher {
/// Wait for all coverage runs to finish.
await Future.wait(currentCoverageResults);

return launcher.runStreamed(Platform.executable, [
'tool/format_coverage.dart', // TODO(jcollins-g): use pub after dart-lang/coverage#240 is landed
return launcher.runStreamed('pub', [
'run',
'coverage:format_coverage',
'--lcov',
'-v',
'-b', '.',
Expand Down
232 changes: 0 additions & 232 deletions tool/format_coverage.dart
View file
Open in desktop

This file was deleted.