Skip to content

Add missing static resource. #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2018
Merged

Add missing static resource. #1708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f7b69e
Add missing static resource.
gspencergoog Jun 7, 2018
b1b455a
Fix analyzer warning in test
gspencergoog Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/html/resources.g.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const List<String> resource_names = const [
'package:dartdoc/resources/favicon.png',
'package:dartdoc/resources/github.css',
'package:dartdoc/resources/highlight.pack.js',
'package:dartdoc/resources/play_button.svg',
'package:dartdoc/resources/readme.md',
'package:dartdoc/resources/script.js',
'package:dartdoc/resources/sdk_footer_text.html',
Expand Down
2 changes: 1 addition & 1 deletion pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,4 +394,4 @@ packages:
source: hosted
version: "2.1.13"
sdks:
dart: "2.0.0-dev.59.0"
dart: ">=2.0.0-dev.59.0 <=2.0.0-dev.60.0"
4 changes: 2 additions & 2 deletions test/model_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,8 @@ void main() {
isTrue);
});
test("Doesn't place animations in one line doc", () {
expect(withAnimationInline.oneLineDoc, isNot(contains('<video')));
expect(withAnimationInline.documentation, contains('<video'));
expect(withAnimationInOneLineDoc.oneLineDoc, isNot(contains('<video')));
expect(withAnimationInOneLineDoc.documentation, contains('<video'));
});
test("Handles animations inline properly", () {
expect(withAnimationInline.documentation, isNot(contains(' works')));
Expand Down
4 changes: 2 additions & 2 deletions testing/test_package_docs/fake/ExtendsFutureVoid-class.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ <h2>Methods</h2>
<div class="features">inherited</div>
</dd>
<dt id="then" class="callable inherited">
<span class="name"><a href="fake/ExtendsFutureVoid/then.html">then</a></span><span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span><span class="signature">(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
<span class="returntype parameter">&#8594; Future<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span>
<span class="name"><a href="fake/ExtendsFutureVoid/then.html">then</a></span><span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span><span class="signature">(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
<span class="returntype parameter">&#8594; Future<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span>
</span>
</dt>
<dd class="inherited">
Expand Down
8 changes: 4 additions & 4 deletions testing/test_package_docs/fake/ExtendsFutureVoid/then.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<li><a href="index.html">test_package</a></li>
<li><a href="fake/fake-library.html">fake</a></li>
<li><a href="fake/ExtendsFutureVoid-class.html">ExtendsFutureVoid</a></li>
<li class="self-crumb">then&lt;<wbr><span class="type-parameter">S</span>&gt; abstract method</li>
<li class="self-crumb">then&lt;<wbr><span class="type-parameter">R</span>&gt; abstract method</li>
</ol>
<div class="self-name">then</div>
<form class="search navbar-right" role="search">
Expand Down Expand Up @@ -66,12 +66,12 @@ <h5>ExtendsFutureVoid class</h5>
</div><!--/.sidebar-offcanvas-->

<div class="col-xs-12 col-sm-9 col-md-8 main-content">
<h1>then&lt;<wbr><span class="type-parameter">S</span>&gt; method</h1>
<h1>then&lt;<wbr><span class="type-parameter">R</span>&gt; method</h1>

<section class="multi-line-signature">
<span class="returntype">Future<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span>
<span class="returntype">Future<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span>
<span class="name ">then</span>
&lt;<wbr><span class="type-parameter">S</span>&gt;(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
&lt;<wbr><span class="type-parameter">R</span>&gt;(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
</section>


Expand Down
4 changes: 2 additions & 2 deletions testing/test_package_docs/fake/ImplementsFutureVoid-class.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ <h2>Methods</h2>
<div class="features">inherited</div>
</dd>
<dt id="then" class="callable inherited">
<span class="name"><a href="fake/ImplementsFutureVoid/then.html">then</a></span><span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span><span class="signature">(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
<span class="returntype parameter">&#8594; Future<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span>
<span class="name"><a href="fake/ImplementsFutureVoid/then.html">then</a></span><span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span><span class="signature">(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
<span class="returntype parameter">&#8594; Future<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span>
</span>
</dt>
<dd class="inherited">
Expand Down
8 changes: 4 additions & 4 deletions testing/test_package_docs/fake/ImplementsFutureVoid/then.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<li><a href="index.html">test_package</a></li>
<li><a href="fake/fake-library.html">fake</a></li>
<li><a href="fake/ImplementsFutureVoid-class.html">ImplementsFutureVoid</a></li>
<li class="self-crumb">then&lt;<wbr><span class="type-parameter">S</span>&gt; abstract method</li>
<li class="self-crumb">then&lt;<wbr><span class="type-parameter">R</span>&gt; abstract method</li>
</ol>
<div class="self-name">then</div>
<form class="search navbar-right" role="search">
Expand Down Expand Up @@ -66,12 +66,12 @@ <h5>ImplementsFutureVoid class</h5>
</div><!--/.sidebar-offcanvas-->

<div class="col-xs-12 col-sm-9 col-md-8 main-content">
<h1>then&lt;<wbr><span class="type-parameter">S</span>&gt; method</h1>
<h1>then&lt;<wbr><span class="type-parameter">R</span>&gt; method</h1>

<section class="multi-line-signature">
<span class="returntype">Future<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span>
<span class="returntype">Future<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span>
<span class="name ">then</span>
&lt;<wbr><span class="type-parameter">S</span>&gt;(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">S</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
&lt;<wbr><span class="type-parameter">R</span>&gt;(<wbr><span class="parameter" id="then-param-onValue"><span class="type-annotation">FutureOr<span class="signature">&lt;<wbr><span class="type-parameter">R</span>&gt;</span></span> <span class="parameter-name">onValue</span>(<span class="parameter" id="onValue-param-value"><span class="type-annotation">T</span> <span class="parameter-name">value</span></span>), {</span> <span class="parameter" id="then-param-onError"><span class="type-annotation">Function</span> <span class="parameter-name">onError</span></span> })
</section>


Expand Down
1 change: 1 addition & 0 deletions testing/test_package_docs/static-assets/play_button.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.