Skip to content

Add missing static resource. #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2018
Merged

Conversation

gspencergoog
Copy link
Collaborator

This adds a missing asset to the resources manifest.
I didn't know I needed to run pub run grinder index-resources when I added it...

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jun 7, 2018
@devoncarew
Copy link
Member

@gspencergoog, is this timely? @jcollins-g is out until next wednesday

@gspencergoog
Copy link
Collaborator Author

Well, without it, the play buttons will be missing on animations on the Flutter doc site. There aren't a lot of them yet, but I'd like to fix it.

@devoncarew
Copy link
Member

ok, gotcha.

I think to get travis green, you'll need to run grind update-test-package-docs (as per https://github.com/dart-lang/dartdoc/blob/master/CONTRIBUTING.md).

@devoncarew
Copy link
Member

I didn't know I needed to run pub run grinder index-resources when I added it...

We should likely add a travis check for that, or in-line generation into something else, like update-test-package-docs. /cc @jcollins-g

@gspencergoog
Copy link
Collaborator Author

gspencergoog commented Jun 7, 2018

Yes, a Travis check to make sure that the resource manifest doesn't change if you run grind index-resources would be good.

@gspencergoog
Copy link
Collaborator Author

Thanks for the review @devoncarew! (I don't have write access, so you'll have to commit it for me... :-))

@devoncarew devoncarew merged commit 718e86d into dart-lang:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants