-
Notifications
You must be signed in to change notification settings - Fork 125
Add "Menlo" to monospace font list. #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, but use grind update-test-package-docs to fix the travis failure. |
I've run |
That doesn't look like it is your break. Something is wrong with sdk doc generation (or, we're correct and verifying the wrong thing if they've changed the SDK somehow). I'll look into it. |
#1650 will alleviate the travis failure. |
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)). Closes dart-lang#1644
Rebased, PTAL. |
lgtm |
i may land more changes. assuming the tests are green go ahead and land after rebasing |
@jcollins-g: I don't have merge rights... |
Actually, I'll just land this myself right now; I'm hoping to gear up for another release sometime today and want this to make it. |
@isoos Oh. Not clear to me how to tell on that sort of thing. Merging :-) |
Thanks! :) |
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).
Closes #1644