Skip to content

Add "Menlo" to monospace font list. #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Conversation

isoos
Copy link
Contributor

@isoos isoos commented Mar 27, 2018

"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes #1644

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Mar 27, 2018
@jcollins-g
Copy link
Contributor

Looks good, but use grind update-test-package-docs to fix the travis failure.

@isoos
Copy link
Contributor Author

isoos commented Mar 28, 2018

I've run pub run grinder grind update-test-package-docs, updated the PR, but I'm not sure why the CI is still failing.

@jcollins-g
Copy link
Contributor

That doesn't look like it is your break. Something is wrong with sdk doc generation (or, we're correct and verifying the wrong thing if they've changed the SDK somehow). I'll look into it.

@jcollins-g
Copy link
Contributor

#1650 will alleviate the travis failure.

"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes dart-lang#1644
@isoos
Copy link
Contributor Author

isoos commented Mar 29, 2018

Rebased, PTAL.

@jcollins-g
Copy link
Contributor

lgtm

@jcollins-g
Copy link
Contributor

i may land more changes. assuming the tests are green go ahead and land after rebasing

@isoos
Copy link
Contributor Author

isoos commented Mar 29, 2018

@jcollins-g: I don't have merge rights...

@jcollins-g
Copy link
Contributor

Actually, I'll just land this myself right now; I'm hoping to gear up for another release sometime today and want this to make it.

@jcollins-g
Copy link
Contributor

@isoos Oh. Not clear to me how to tell on that sort of thing. Merging :-)

@jcollins-g jcollins-g merged commit b1c2a5d into dart-lang:master Mar 29, 2018
@isoos isoos deleted the patch-1 branch March 29, 2018 15:59
@isoos
Copy link
Contributor Author

isoos commented Mar 29, 2018

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match GitHub fonts for pretty print
3 participants