Skip to content

Match GitHub fonts for pretty print #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isoos opened this issue Mar 26, 2018 · 1 comment · Fixed by #1647
Closed

Match GitHub fonts for pretty print #1644

isoos opened this issue Mar 26, 2018 · 1 comment · Fixed by #1647
Labels
P2 A bug or feature request we're likely to work on

Comments

@isoos
Copy link
Contributor

isoos commented Mar 26, 2018

The current font makes certain table lines too long.

GitHub uses font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace; which the pub site will match. I'm happy to create a PR here too, just wanted to check if there is any preference of one font over the other.
@isoos isoos mentioned this issue Mar 26, 2018
Closed
@jcollins-g
Copy link
Contributor

I have no preference; please go ahead and file a PR preferably with screenshot(s).

@jcollins-g jcollins-g added P3 A lower priority bug or feature request P2 A bug or feature request we're likely to work on and removed P3 A lower priority bug or feature request labels Mar 26, 2018
isoos added a commit to isoos/dartdoc that referenced this issue Mar 27, 2018
@isoos
Add "Menlo" to monospace font list.
ecaf9a4 
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes dart-lang#1644
@isoos isoos mentioned this issue Mar 27, 2018
Merged
isoos added a commit to isoos/dartdoc that referenced this issue Mar 28, 2018
@isoos
Add "Menlo" to monospace font list.
3c84d69 
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes dart-lang#1644
isoos added a commit to isoos/dartdoc that referenced this issue Mar 29, 2018
@isoos
Add "Menlo" to monospace font list.
0260a8a 
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes dart-lang#1644
jcollins-g pushed a commit that referenced this issue Mar 29, 2018
@isoos @jcollins-g
Add "Menlo" to monospace font list. (#1647)
b1c2a5d 
"Source Code Pro" is not installed on Mac, and the default monospace font makes the table's markdown-formatted fixed table's header line stick out. (Screenshots in this issue thread: dart-lang/pub-dev#1125 (comment)).

Closes #1644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "Menlo" to monospace font list. isoos/dartdoc
2 participants
@isoos @jcollins-g