Skip to content

Rename category to package in remaining places #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 16, 2018
Merged

Rename category to package in remaining places #1636

merged 14 commits into from
Mar 16, 2018

Conversation

jcollins-g
Copy link
Contributor

Preparing for the fix to #1610, rename flags and classes to expunge the old idea of "categories".

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Mar 16, 2018
@jcollins-g jcollins-g requested review from devoncarew, keertip and pq March 16, 2018 21:01
pq
pq approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcollins-g jcollins-g merged commit 4214525 into master Mar 16, 2018
@jcollins-g jcollins-g deleted the category-redo branch March 16, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

@keertip keertip Awaiting requested review from keertip

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @pq @googlebot