Skip to content

Support custom categories for libraries within a package – and the SDK #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Feb 23, 2018 · 9 comments
Closed
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 23, 2018

Allow organizing the libraries (on the left side of nav) into custom categories

Blocking dart-lang/sdk#32297

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 23, 2018
@jcollins-g
Copy link
Contributor

marking as P2 based on dartdoc triage priority (enhancements considered important but with no data indicating they are a big win)

@jcollins-g jcollins-g added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 23, 2018
@kevmoo
Copy link
Member Author

kevmoo commented Feb 23, 2018

I'd argue for P1 just because we are moving some dart: apis from core to VM – mirrors and isolates – and we want to help folks understand where they can be used!

@jcollins-g
Copy link
Contributor

jcollins-g commented Feb 26, 2018

Didn't realize/see this was blocking a P1 bug on the SDK side. Agree then with prioritization: moving to P1 and will address after strong mode changes land.

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Feb 26, 2018
@kevmoo
Copy link
Member Author

kevmoo commented Feb 26, 2018 via email

@jcollins-g
Copy link
Contributor

jcollins-g commented Mar 14, 2018

@kevmoo Just to let you know I haven't forgotten this. With #1625 out of the way, now working on a steel thread through dartdoc to make dartdoc_options.yaml real. But before I get much further, I'll outline the planned outcome:

dartdoc_options.yaml will understand (for now) exactly two fields, one for listing the subcategorization, and another for sorting the subcategories.

Then we drop a dartdoc_options.yaml into the SDK like so:

dartdoc:
  subCategoryOrder: ['VM', 'Web']
  subCategories:
    VM: ['dart:io', 'dart:cli']
    Web:
      - 'dart:html'
      - 'dart:indexed_db'
      - 'dart:js'
      - 'dart:js_util'
      - 'dart:svg'
      - 'dart:web_audio'
      - 'dart:web_gl'
      - 'dart:web_sql'

Dartdoc will show uncategorized items in the sidebar first, then will organize the others as listed under subheadings.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 14, 2018 via email

@jcollins-g
Copy link
Contributor

This is now close enough for screenshots:

screenshot from 2018-03-20 15-19-41

No PR yet (blocked by #1639) but I uploaded the branch for experimentation: https://github.com/dart-lang/dartdoc/tree/dartdoc-categories.

The new version requires a {@category VM} tag in the library documentation for libraries you want to tag. This is more scalable and fits better with the need described in #1353.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 20, 2018 via email

@devoncarew
Copy link
Member

🎆 !

You might consider adding a Core category for everything not in VM and Web; that would help the different libraries had the same indent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants