Compare flutter warnings between versions very easily #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2018
devoncarew
approved these changes
Feb 6, 2018
| final Map<String, int> _warningKeyCounts; | ||
| final String branch; | ||
| final String pubCachePath; | ||
| WarningsCollection(this.tempDir, this.pubCachePath, this.branch) |
There was a problem hiding this comment.
was this dartfmt'd? I would have thought it would insert a newline between the field and the ctor.
There was a problem hiding this comment.
I did forget to run dartfmt, but it did not do that even when run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a grinder that can compare flutter warnings between versions very easily and serve both versions alongside each other so you can check them for differences. I do this manually before releases, but making an automated version should help us catch problems faster.