Skip to content

flutter docs generated from head don't know about Dart Core #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Feb 5, 2018 · 5 comments · Fixed by #1605
Closed

flutter docs generated from head don't know about Dart Core #1601

jcollins-g opened this issue Feb 5, 2018 · 5 comments · Fixed by #1605
Assignees
Labels
customer-flutter Issues originating from important to Flutter P0 A serious issue requiring immediate resolution

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Feb 5, 2018

Since the analysis driver transition in #1598 it looks like Flutter docs call Dart "Sky Engine" instead of recognizing those libraries are the dart SDK. Probably something wrong with how we're doing embedded SDKs again -- that was it last time this happened (#1107).

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-flutter Issues originating from important to Flutter labels Feb 5, 2018
@jcollins-g jcollins-g self-assigned this Feb 5, 2018
@jcollins-g
Copy link
Contributor Author

jcollins-g commented Feb 5, 2018

This was found thanks to the development of #1600. P1 as it is a minor display wart impacting the front page with high impact.

@devoncarew
Copy link
Member

/cc @scheglov - he may know about whether the driver handles the _embedder.yaml extensions (https://github.com/flutter/engine/blob/master/sky/packages/sky_engine/lib/_embedder.yaml).

@scheglov
Copy link
Contributor

scheglov commented Feb 6, 2018

The driver gets already created SourceFactory, with SDK and packages configured.

I see that we handle _embedder.yaml in ContextBuilder.

@jcollins-g
Copy link
Contributor Author

We do something similar in dartdoc too, but apparently what we needed to do changed subtly (and because I didn't have #1600 yet I didn't notice it right away).

@jcollins-g
Copy link
Contributor Author

Changing to P0, because this also impacts navigation as canonicalization loses its mind when it doesn't have an SDK. Dartdoc emits hundreds of warnings and mislinks things due to canonicalization errors. Fortunately, we haven't shipped a release with the driver change yet.

@jcollins-g jcollins-g added P0 A serious issue requiring immediate resolution and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P0 A serious issue requiring immediate resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants