-
Notifications
You must be signed in to change notification settings - Fork 125
flutter docs generated from head don't know about Dart Core #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was found thanks to the development of #1600. P1 as it is a minor display wart impacting the front page with high impact. |
/cc @scheglov - he may know about whether the driver handles the _embedder.yaml extensions (https://github.com/flutter/engine/blob/master/sky/packages/sky_engine/lib/_embedder.yaml). |
The driver gets already created I see that we handle |
We do something similar in dartdoc too, but apparently what we needed to do changed subtly (and because I didn't have #1600 yet I didn't notice it right away). |
Changing to P0, because this also impacts navigation as canonicalization loses its mind when it doesn't have an SDK. Dartdoc emits hundreds of warnings and mislinks things due to canonicalization errors. Fortunately, we haven't shipped a release with the driver change yet. |
Since the analysis driver transition in #1598 it looks like Flutter docs call Dart "Sky Engine" instead of recognizing those libraries are the dart SDK. Probably something wrong with how we're doing embedded SDKs again -- that was it last time this happened (#1107).
The text was updated successfully, but these errors were encountered: