Skip to content

Revert memoizer integration #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Revert memoizer integration #1594

merged 4 commits into from
Jan 12, 2018

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Jan 12, 2018

The memoizer is just too slow for the benefits it provides. Revert.

Tail of output from grind compare-sdk-warnings. Original is the master branch, 'current' is this one.

build-sdk-docs-original:     in documentation inherited from dart-web_audio.ScriptProcessorNode.onAudioProcess: (file:///usr/local/google/home/jcollins/dart/all_sdks/2.0.0-dev.16.0/lib/web_audio/dart2js/web_audio_dart2js.dart:1112:36)
build-sdk-docs-original: Generating docs for library dart:web_gl from dart:web_gl...
build-sdk-docs-original: Generating docs for library dart:web_sql from dart:web_sql...
build-sdk-docs-original: Validating docs...
build-sdk-docs-current: found 26 warnings and 0 errors
build-sdk-docs-current: Documented 18 public libraries in 252.7 seconds
build-sdk-docs-current: Success! Docs generated into /tmp/sdkdocsDFWEDR
build-sdk-docs-original: found 26 warnings and 0 errors
build-sdk-docs-original: Documented 18 public libraries in 354.9 seconds
build-sdk-docs-original: Success! Docs generated into /tmp/sdkdocsDFWEDR
*** SDK docs : No difference in warning output from original (master) (26 warnings found)

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 12, 2018
@jcollins-g jcollins-g merged commit a96607b into master Jan 12, 2018
@jcollins-g jcollins-g deleted the memoizer-revert branch January 12, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants