Skip to content

Use the Memoizer class in place of ad-hoc caching in model.dart #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 5, 2018
Merged

Use the Memoizer class in place of ad-hoc caching in model.dart #1577

merged 8 commits into from
Jan 5, 2018

Conversation

jcollins-g
Copy link
Contributor

This is a mechanical translation to using the features of the Memoizer (#1571) for the repetitive caching in model.dart.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 22, 2017
devoncarew
devoncarew approved these changes Jan 2, 2018
View reviewed changes
lib/src/model.dart Outdated
}
} else {
_canonicalLibrary = definingLibrary;
if (candidateLibraries.isNotEmpty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

braces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jcollins-g jcollins-g merged commit be310b8 into master Jan 5, 2018
@jcollins-g jcollins-g deleted the memoize-all-the-things branch January 5, 2018 17:54
jcollins-g added a commit that referenced this pull request Jan 12, 2018
@jcollins-g
Revert "Use the Memoizer class in place of ad-hoc caching in model.da…
cb9e3cf 
…rt (#1577)"

This reverts commit be310b8.
jcollins-g added a commit that referenced this pull request Jan 12, 2018
@jcollins-g
Revert memoizer integration (#1594)
a96607b 
* Revert "Use the Memoizer class in place of ad-hoc caching in model.dart (#1577)"

This reverts commit be310b8.

* Merge error broke canonicalModelElement, fixed

* dartfmt

* Pin travis to 16 too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@keertip keertip Awaiting requested review from keertip

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @devoncarew @googlebot