Change the --include-external flag to be more selective #1289
Conversation
|
Awesome! lgtm We when this lands in the sdk, we should rev. the flutter script to use the updated params (and to pull from the dartdoc in the sdk). |
|
@devoncarew should we open an issue on Flutter side so we don't forget? |
|
👍 sounds good |
|
I happened to notice that Travis was a sad panda, just FYI: |
|
Yup, fixed in #1291. |
| @@ -252,12 +252,13 @@ class DartDoc { | |||
| while (result.hasMoreWork) { | |||
| result = context.performAnalysisTask(); | |||
| } | |||
|
|
|||
| // Use the includeExternals. | |||
| for (Source source in context.librarySources) { | |||
| LibraryElement library = context.computeLibraryElement(source); | |||
There was a problem hiding this comment.
This and libraryName are no longer used in the case where the library doesn't match. No clue if it's expensive or not. (Sorry to keep commenting on your completed CL, was just playing around in this code and noticed.) Thanks again for the fix! :)
There was a problem hiding this comment.
We can always optimize! Though you will see a slowdown once flutter is back to generating all the docs, I saw ~20 sec difference on my machine between the two cases.
Fixes #1236
@devoncarew