operator== becomes == #1287
Closed
operator== becomes == #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting - we're using the same analyzer, but generating against two different SDKs (the current stable and the dev channel SDK). We're working against dev but not against stable. |
|
I think you can make travis happy by only running the tests against the dev channel. Commenting out this line: https://github.com/dart-lang/dartdoc/blob/master/.travis.yml#L5 - should do it. Let's file an issue to re-enable once dev goes stable. lgtm once travis goes green; thanks! |
This was referenced Dec 14, 2016
|
Looks like you guys already did this part. |
|
Yup, but thanks anyway! (we had an important change to get in and wanted the bots green for it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly the result of an analyzer change beneath us, it looks like how the == operator method is represented has changed. @keertip @devoncarew