Skip to content

Clicking search result while on non-root page goes to page not found #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdkoren opened this issue Jan 10, 2020 · 0 comments · Fixed by #2125
Closed

Clicking search result while on non-root page goes to page not found #2124

jdkoren opened this issue Jan 10, 2020 · 0 comments · Fixed by #2125
Assignees
Labels
P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jdkoren
Copy link
Contributor

jdkoren commented Jan 10, 2020

On v0.30.0+1. If you are on a non-root page and use the search bar, clicking a search result goes to a nonexistent page. Steps to reproduce:

  1. grind serve-test-package-docs
  2. Open a browser window and navigate to the served pages on localhost.
  3. Enter some text in the search bar and click on a result.
    • On the root page, this should work just fine.
    • On any other page, it will most likely go to a page that doesn't exist. [BUG]

Similar problem as #2117, but it's the search result items rather than the script itself. The script constructs a list where each item uses an incomplete href, expecting base href to take care of the rest. Source

@jdkoren jdkoren added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P0 A serious issue requiring immediate resolution labels Jan 10, 2020
@jdkoren jdkoren self-assigned this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant