Skip to content

search has stopped working except on the root page #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Jan 9, 2020 · 1 comment · Fixed by #2118
Closed

search has stopped working except on the root page #2117

jcollins-g opened this issue Jan 9, 2020 · 1 comment · Fixed by #2118
Labels
P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jcollins-g
Copy link
Contributor

Didn't notice this right away, but it looks like search is no longer working except on the root page. Other pages get "loading..." messages. Probably related to base href.

@jdkoren
@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P0 A serious issue requiring immediate resolution labels Jan 9, 2020
@jcollins-g
Copy link
Contributor Author

It's our hand-coded javascript doing jsonReq.open('GET', 'index.json', true); depending on baseHref to fix things for us.

@jcollins-g jcollins-g mentioned this issue Jan 9, 2020
Merged
This was referenced Jan 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 A serious issue requiring immediate resolution type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix basehref for search box on non-root cases dart-lang/dartdoc
1 participant
@jcollins-g