Fixes #1902. Existing tests adopted for patterns and records #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Mar 7, 2023
There was a problem hiding this comment.
I think we ought to preserve a few lines of code which are otherwise deleted from Language/Reference/Lexical_Rules/Reserved_Words/is_t05.dart.
Other than that I've just added some comments on formatting and typos, and a couple of outright opinionated remarks. ;-)
| // ^ | ||
| // [analyzer] unspecified | ||
| // [cfe] unspecified | ||
| case 1: |
There was a problem hiding this comment.
Do we actually have any rules about how to treat a switch statement where the body is just one sequence of cases with no body? It's not even a single case group, because not even the last case has anything in its body.
It might be considered to be similar to a switch which is non-exhaustive (in situations where we know that kind of thing), but if we keep this test then we have decided that it's OK.
OK, having thought about this for a bit: Seems like we have been doing that for years, so let's just keep it like that!
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 9, 2023
2023-03-09 [email protected] dart-lang/co19#1401. Matching tests added (dart-lang/co19#1894) 2023-03-09 [email protected] dart-lang/co19#1401. Type inference. The last part of the tests (dart-lang/co19#1859) 2023-03-09 [email protected] Fixes dart-lang/co19#1913. Update generated tests to work with class-modifiers (dart-lang/co19#1914) 2023-03-08 [email protected] Fixes dart-lang/co19#1909. Update tests not to fail with patterns feature enabled (dart-lang/co19#1910) 2023-03-08 [email protected] Fixes dart-lang/co19#1876. Don't expect type promotion in shared_case_scope_A02_t03 (dart-lang/co19#1880) 2023-03-08 [email protected] dart-lang/co19#1401. Pattern-for-in statement and element tests (dart-lang/co19#1872) 2023-03-08 [email protected] Added overloaded hashCode getter which is in accordance with == operator (dart-lang/co19#1911) 2023-03-08 [email protected] dart-lang/co19#1401. Execution of pattern-for statement and element. Switch expression (dart-lang/co19#1870) 2023-03-07 [email protected] dart-lang/co19#1401. Test for matching logical and relational patterns (dart-lang/co19#1888) 2023-03-07 [email protected] dart-lang/co19#1401. Pattern-if-case statement and element tests (dart-lang/co19#1873) 2023-03-07 [email protected] Fixes dart-lang/co19#1902. Existing tests adopted for patterns and records (dart-lang/co19#1908) 2023-03-07 [email protected] Fixes dart-lang/co19#1899. Language version 2.19 added to legacy mixins tests (dart-lang/co19#1907) 2023-03-06 [email protected] Fixes dart-lang/co19#1896. Update type inference tests failures (dart-lang/co19#1903) 2023-03-06 [email protected] Fixes dart-lang/co19#1901. Add `void` to prevent wrong failure (dart-lang/co19#1906) 2023-03-06 [email protected] Fixes dart-lang/co19#1897. Use <Object?> as an expected inferred type for List and Maps (dart-lang/co19#1905) 2023-03-06 [email protected] Fixes dart-lang/co19#1895. Fix runtime type used in the test (dart-lang/co19#1904) Change-Id: I4fc8fc07c2213f5fa05851db06bed3979d36ff52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287841 Commit-Queue: Jake Macdonald <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.