Skip to content

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Mar 7, 2023

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, the only change which is not adding the block TODO ... @dart=2.19 is in generator.dart. I think it's a good approach to put the TODO in all those tests for now. We can then settle the further adjustments later on.

LGTM!

@eernstg eernstg merged commit 92d6ad0 into dart-lang:master Mar 7, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 9, 2023
2023-03-09 [email protected] dart-lang/co19#1401. Matching tests added (dart-lang/co19#1894)
2023-03-09 [email protected] dart-lang/co19#1401. Type inference. The last part of the tests (dart-lang/co19#1859)
2023-03-09 [email protected] Fixes dart-lang/co19#1913. Update generated tests to work with class-modifiers (dart-lang/co19#1914)
2023-03-08 [email protected] Fixes dart-lang/co19#1909. Update tests not to fail with patterns feature enabled (dart-lang/co19#1910)
2023-03-08 [email protected] Fixes dart-lang/co19#1876. Don't expect type promotion in shared_case_scope_A02_t03 (dart-lang/co19#1880)
2023-03-08 [email protected] dart-lang/co19#1401. Pattern-for-in statement and element tests (dart-lang/co19#1872)
2023-03-08 [email protected] Added overloaded hashCode getter which is in accordance with == operator (dart-lang/co19#1911)
2023-03-08 [email protected] dart-lang/co19#1401. Execution of pattern-for statement and element. Switch expression (dart-lang/co19#1870)
2023-03-07 [email protected] dart-lang/co19#1401. Test for matching logical and relational patterns (dart-lang/co19#1888)
2023-03-07 [email protected] dart-lang/co19#1401. Pattern-if-case statement and element tests (dart-lang/co19#1873)
2023-03-07 [email protected] Fixes dart-lang/co19#1902. Existing tests adopted for patterns and records (dart-lang/co19#1908)
2023-03-07 [email protected] Fixes dart-lang/co19#1899. Language version 2.19 added to legacy mixins tests (dart-lang/co19#1907)
2023-03-06 [email protected] Fixes dart-lang/co19#1896. Update type inference tests failures (dart-lang/co19#1903)
2023-03-06 [email protected] Fixes dart-lang/co19#1901. Add `void` to prevent wrong failure (dart-lang/co19#1906)
2023-03-06 [email protected] Fixes dart-lang/co19#1897. Use <Object?> as an expected inferred type  for List and Maps (dart-lang/co19#1905)
2023-03-06 [email protected] Fixes dart-lang/co19#1895. Fix runtime type used in the test (dart-lang/co19#1904)

Change-Id: I4fc8fc07c2213f5fa05851db06bed3979d36ff52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287841
Commit-Queue: Jake Macdonald <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1899 branch March 22, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants