Skip to content

Remove use of Deprecated.expires #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Dec 12, 2022 · 0 comments
Closed

Remove use of Deprecated.expires #1581

mit-mit opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@mit-mit
Copy link
Member

mit-mit commented Dec 12, 2022

The deprecated member Deprecated.expires has been removed:
dart-lang/sdk@7670491

This is currently used in a few places, e.g.:
https://github.com/search?q=repo%3Adart-lang%2Fco19+.expires&type=code

Please remove from co19_2 too.

@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 12, 2022
@sgrekhov sgrekhov self-assigned this Dec 12, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 13, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 13, 2022
eernstg pushed a commit that referenced this issue Dec 13, 2022
eernstg pushed a commit that referenced this issue Dec 13, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 16, 2022
2022-12-15 [email protected] Fixes dart-lang/co19#1595. Expect TypeError in place of NullThrownError in co19_2 tests (dart-lang/co19#1597)
2022-12-14 [email protected] dart-lang/co19#1586. Remove CyclicInitializationError from co19_2 tests (dart-lang/co19#1591)
2022-12-13 [email protected] dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1585)

Change-Id: Icbf31546935281067815d59957ed2ddc7e262546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275921
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 16, 2022
2022-12-14 [email protected] Fixes dart-lang/co19#1589. Fix wrong expectation in relational tests (dart-lang/co19#1594)
2022-12-14 [email protected] Fixes dart-lang/co19#1588. Fix testing of 'logical-and' subpattern (dart-lang/co19#1593)
2022-12-14 [email protected] dart-lang/co19#1587. Fix testing of 'logical-or' subpattern (dart-lang/co19#1592)
2022-12-14 [email protected] dart-lang/co19#1540. Tests error expectations updated (dart-lang/co19#1543)
2022-12-14 [email protected] dart-lang/co19#1596. Remove CyclicInitializationError from co19 tests (dart-lang/co19#1590)
2022-12-13 [email protected] dart-lang/co19#1401. [Patterns] Switch expressions fixed according to the new syntax (dart-lang/co19#1583)
2022-12-13 [email protected] dart-lang/co19#1401. [Patterns] Record pattern tests added (dart-lang/co19#1580)
2022-12-13 [email protected] dart-lang/co19#1581. Remove use of Deprecated.expires (dart-lang/co19#1584)
2022-12-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.6.0 to 3.8.0 (dart-lang/co19#1582)

Change-Id: I57f679a9cf6dc9063d5fdfcc630831a2a29abba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275920
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants