[3.0 alpha] Remove deprecated dart:core apis

  - Remove `proxy` and `Provisional` annotations.
  - Remove `Deprecated.expires` getter.

Change-Id: I4521b48bb92e5f8420c778686f4efa9c6426cebb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258004
Commit-Queue: Lasse Nielsen <[email protected]>
Reviewed-by: Brian Quinlan <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>

Author: lrhn

CHANGELOG.md

@@ -7,10 +7,21 @@
 - **Breaking change** [#49529][]:
   - Removed the deprecated [`NoSuchMethodError`][] default constructor.
     Use the [`NoSuchMethodError.withInvocation`][] named constructor instead.
+  - Removed the deprecated [`proxy`][] and [`Provisional`][] annotations.
+    The original `proxy` annotation has no effect in Dart 2,
+    and the `Provisional` type and [`provisional`][] constant
+    were only used internally during the Dart 2.0 development process.
+  - Removed the deprecated [`Deprecated.expires`][] getter.
+    Use [`Deprecated.message`][] instead.
 
 [#49529]: https://github.com/dart-lang/sdk/issues/49529
+[`Deprecated.expires`]: https://api.dart.dev/stable/2.18.4/dart-core/Deprecated/expires.html
+[`Deprecated.message`]: https://api.dart.dev/stable/2.18.4/dart-core/Deprecated/message.html
 [`NoSuchMethodError`]: https://api.dart.dev/stable/2.18.4/dart-core/NoSuchMethodError/NoSuchMethodError.html
 [`NoSuchMethodError.withInvocation`]: https://api.dart.dev/stable/2.18.4/dart-core/NoSuchMethodError/NoSuchMethodError.withInvocation.html
+[`Provisional`]: https://api.dart.dev/stable/2.18.4/dart-core/Provisional-class.html
+[`provisional`]: https://api.dart.dev/stable/2.18.4/dart-core/provisional-constant.html
+[`proxy`]: https://api.dart.dev/stable/2.18.4/dart-core/proxy-constant.html
 
 #### `dart:html`
 
@@ -130,7 +141,6 @@
   constructor.
 - Deprecated `NullThrownError` and `CyclicInitializationError`.
   Neither error is thrown by null safe code.
-
 [#49529]: https://github.com/dart-lang/sdk/issues/49529
 [#24644]: https://github.com/dart-lang/sdk/issues/24644
 
@@ -342,7 +352,7 @@ Updated the Linter to `1.31.0`, which includes changes that
 - Update `dart pub publish` to require a working resolution.
   If publishing a breaking release of mutually dependent packages use `dependency_overrides`
   to obtain a resolution.
-- `dart pub add` will now allow adding multiple packages from any source using 
+- `dart pub add` will now allow adding multiple packages from any source using
   the same YAML syntax as in `pubspec.yaml`.
 
   For example:

pkg/analyzer/lib/src/dart/element/element.dart

@@ -1943,10 +1943,6 @@ class ElementAnnotationImpl implements ElementAnnotation {
   /// protected.
   static const String _protectedVariableName = 'protected';
 
-  /// The name of the top-level variable used to mark a class as implementing a
-  /// proxy object.
-  static const String _proxyVariableName = 'proxy';
-
   /// The name of the class used to mark a parameter as being required.
   static const String _requiredClassName = 'Required';
 
@@ -2081,7 +2077,7 @@ class ElementAnnotationImpl implements ElementAnnotation {
   bool get isProtected => _isPackageMetaGetter(_protectedVariableName);
 
   @override
-  bool get isProxy => _isDartCoreGetter(_proxyVariableName);
+  bool get isProxy => false;
 
   @override
   bool get isRequired =>

pkg/analyzer/lib/src/test_utilities/mock_sdk.dart

@@ -274,8 +274,6 @@ const deprecated = const Deprecated("next release");
 
 const override = const _Override();
 
-const proxy = const _Proxy();
-
 external bool identical(Object? a, Object? b);
 
 void print(Object? object) {}
@@ -318,8 +316,8 @@ class DateTime extends Object {
 }
 
 class Deprecated extends Object {
-  final String expires;
-  const Deprecated(this.expires);
+  final String message;
+  const Deprecated(this.message);
 }
 
 class pragma {
@@ -669,10 +667,6 @@ class _Override {
   const _Override();
 }
 
-class _Proxy {
-  const _Proxy();
-}
-
 @Since("2.15")
 extension EnumName on Enum {
   String get name => _name;

pkg/analyzer/lib/src/test_utilities/mock_sdk_elements.dart

@@ -52,7 +52,6 @@ class _MockSdkElementsBuilder {
   ClassElementImpl? _numElement;
   ClassElementImpl? _objectElement;
   ClassElementImpl? _overrideElement;
-  ClassElementImpl? _proxyElement;
   ClassElementImpl? _recordElement;
   ClassElementImpl? _setElement;
   ClassElementImpl? _stackTraceElement;
@@ -628,20 +627,6 @@ class _MockSdkElementsBuilder {
     return overrideElement;
   }
 
-  ClassElementImpl get proxyElement {
-    var proxyElement = _proxyElement;
-    if (proxyElement != null) return proxyElement;
-
-    _proxyElement = proxyElement = _class(name: '_Proxy');
-    proxyElement.supertype = objectType;
-
-    proxyElement.constructors = [
-      _constructor(isConst: true),
-    ];
-
-    return proxyElement;
-  }
-
   ClassElementImpl get recordElement {
     var recordElement = _recordElement;
     if (recordElement != null) return recordElement;
@@ -930,7 +915,6 @@ class _MockSdkElementsBuilder {
       numElement,
       objectElement,
       overrideElement,
-      proxyElement,
       recordElement,
       setElement,
       stackTraceElement,
@@ -959,20 +943,13 @@ class _MockSdkElementsBuilder {
       _interfaceType(overrideElement),
     );
 
-    var proxyVariable = _topLevelVariableConst(
-      'proxy',
-      _interfaceType(proxyElement),
-    );
-
     coreUnit.accessors = <PropertyAccessorElementImpl>[
       deprecatedVariable.getter!,
       overrideVariable.getter!,
-      proxyVariable.getter!,
     ];
     coreUnit.topLevelVariables = <TopLevelVariableElementImpl>[
       deprecatedVariable,
       overrideVariable,
-      proxyVariable,
     ];
 
     var coreLibrary = LibraryElementImpl(

pkg/analyzer/test/generated/non_hint_code_test.dart

@@ -78,70 +78,6 @@ class Z {
 ''');
   }
 
-  test_proxy_annotation_prefixed() async {
-    await assertErrorsInCode(r'''
-library L;
-@proxy
-class A {}
-f(var a) {
-  a = new A();
-  a.m();
-  var x = a.g;
-  a.s = 1;
-  var y = a + a;
-  a++;
-  ++a;
-}
-''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 70, 1),
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 96, 1),
-    ]);
-  }
-
-  test_proxy_annotation_prefixed2() async {
-    await assertErrorsInCode(r'''
-library L;
-@proxy
-class A {}
-class B {
-  f(var a) {
-    a = new A();
-    a.m();
-    var x = a.g;
-    a.s = 1;
-    var y = a + a;
-    a++;
-    ++a;
-  }
-}
-''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 88, 1),
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 118, 1),
-    ]);
-  }
-
-  test_proxy_annotation_prefixed3() async {
-    await assertErrorsInCode(r'''
-library L;
-class B {
-  f(var a) {
-    a = new A();
-    a.m();
-    var x = a.g;
-    a.s = 1;
-    var y = a + a;
-    a++;
-    ++a;
-  }
-}
-@proxy
-class A {}
-''', [
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 70, 1),
-      error(HintCode.UNUSED_LOCAL_VARIABLE, 100, 1),
-    ]);
-  }
-
   test_undefinedMethod_assignmentExpression_inSubtype() async {
     await assertNoErrorsInCode(r'''
 class A {}

pkg/analyzer/test/src/diagnostics/undefined_getter_test.dart

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2019, the Dart propject authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
@@ -463,22 +463,6 @@ void f(A a) {
 ''');
   }
 
-  test_proxy_annotation_fakeProxy() async {
-    await assertErrorsInCode(r'''
-library L;
-class Fake {
-  const Fake();
-}
-const proxy = const Fake();
-@proxy class PrefixProxy {}
-main() {
-  new PrefixProxy().foo;
-}
-''', [
-      error(CompileTimeErrorCode.UNDEFINED_GETTER, 127, 3),
-    ]);
-  }
-
   test_static_conditionalAccess_defined() async {
     await assertErrorsInCode(
       '''

pkg/analyzer/test/src/task/strong/checker_test.dart

@@ -2825,53 +2825,6 @@ class Child extends helper.Base {
     ]);
   }
 
-  test_proxy() {
-    return assertErrorsInCode(r'''
-@proxy class C {}
-@proxy class D {
-  var f;
-  m() => null;
-  operator -() => null;
-  operator +(int other) => null;
-  operator [](int index) => null;
-  call() => null;
-}
-
-@proxy class F implements Function { noSuchMethod(i) => 42; }
-
-m() {
-  D d = new D();
-  d.m();
-  d.m;
-  d.f;
-  -d;
-  d + 7;
-  d[7];
-  d();
-
-  C c = new C();
-  c.m();
-  c.m;
-  -c;
-  c + 7;
-  c[7];
-  c();
-
-  F f = new F();
-  f();
-}
-''', [
-      error(HintCode.DEPRECATED_IMPLEMENTS_FUNCTION, 197, 8),
-      error(CompileTimeErrorCode.UNDEFINED_METHOD, 332, 1),
-      error(CompileTimeErrorCode.UNDEFINED_GETTER, 341, 1),
-      error(CompileTimeErrorCode.UNDEFINED_OPERATOR, 346, 1),
-      error(CompileTimeErrorCode.UNDEFINED_OPERATOR, 354, 1),
-      error(CompileTimeErrorCode.UNDEFINED_OPERATOR, 362, 3),
-      error(CompileTimeErrorCode.INVOCATION_OF_NON_FUNCTION_EXPRESSION, 369, 1),
-      error(CompileTimeErrorCode.INVOCATION_OF_NON_FUNCTION_EXPRESSION, 394, 1),
-    ]);
-  }
-
   test_redirectingConstructor() async {
     await assertErrorsInCode('''
 class A {

pkg/analyzer_cli/test/data/sky_engine/lib/core.dart

@@ -65,8 +65,8 @@ class DateTime extends Object {}
 class Null extends Object {}
 
 class Deprecated extends Object {
-  final String expires;
-  const Deprecated(this.expires);
+  final String message;
+  const Deprecated(this.message);
 }
 
 const Object deprecated = const Deprecated("next release");

pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.expect

@@ -93,7 +93,6 @@ import self as self2;
 import "dart:core" as core;
 import "dart:async" as asy;
 additionalExports = (core::Deprecated,
-  core::Provisional,
   core::pragma,
   core::BigInt,
   core::bool,
@@ -164,8 +163,6 @@ additionalExports = (core::Deprecated,
   core::Comparator,
   core::deprecated,
   core::override,
-  core::provisional,
-  core::proxy,
   asy::Future,
   asy::Stream,
   asy::FutureExtensions)

pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.outline.expect

@@ -28,7 +28,6 @@ import self as self2;
 import "dart:core" as core;
 import "dart:async" as asy;
 additionalExports = (core::Deprecated,
-  core::Provisional,
   core::pragma,
   core::BigInt,
   core::bool,
@@ -99,8 +98,6 @@ additionalExports = (core::Deprecated,
   core::Comparator,
   core::deprecated,
   core::override,
-  core::provisional,
-  core::proxy,
   asy::Future,
   asy::Stream,
   asy::FutureExtensions)