Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

check declared var patterns in constant_identifier_names #3979

Merged
merged 1 commit into from
Jan 9, 2023
Merged

check declared var patterns in constant_identifier_names #3979

merged 1 commit into from
Jan 9, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Jan 9, 2023

@github-actions github-actions bot added the linter-set-recommended Affects a rule in the recommended Dart rule set label Jan 9, 2023
@coveralls
Copy link

Coverage Status

Coverage: 95.688% (+0.001%) from 95.687% when pulling b22a6cd on constant_identifier_names_patterns into 2101a0a on main.

bwilkerson
bwilkerson approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are variables declared in patterns automatically constants? If so, lgtm.

@pq pq merged commit 514d0d5 into main Jan 9, 2023
@pq pq deleted the constant_identifier_names_patterns branch January 9, 2023 23:48
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
check declared var patterns in constant_identifier_names (dart-arch…
4804e6d 
…ive/linter#3979)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
linter-set-recommended Affects a rule in the recommended Dart rule set
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend constant_identifier_names for destructured final variable declarations
3 participants
@pq @coveralls @bwilkerson