check declared var patterns in constant_identifier_names (dart-archive/linter#3979)

Author: pq

lib/src/rules/constant_identifier_names.dart

@@ -63,6 +63,7 @@ class ConstantIdentifierNames extends LintRule {
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
     var visitor = _Visitor(this);
+    registry.addDeclaredVariablePattern(this, visitor);
     registry.addEnumConstantDeclaration(this, visitor);
     registry.addTopLevelVariableDeclaration(this, visitor);
     registry.addVariableDeclarationList(this, visitor);
@@ -81,6 +82,11 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 
+  @override
+  void visitDeclaredVariablePattern(DeclaredVariablePattern node) {
+    checkIdentifier(node.name);
+  }
+
   @override
   void visitEnumConstantDeclaration(EnumConstantDeclaration node) {
     checkIdentifier(node.name);

test/rules/constant_identifier_names_test.dart

@@ -9,9 +9,47 @@ import '../rule_test_support.dart';
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(ConstantIdentifierNamesRecordsTest);
+    defineReflectiveTests(ConstantIdentifierNamesPatternsTest);
   });
 }
 
+@reflectiveTest
+class ConstantIdentifierNamesPatternsTest extends LintRuleTest {
+  @override
+  List<String> get experiments => ['patterns', 'records'];
+
+  @override
+  String get lintRule => 'constant_identifier_names';
+
+  test_destructuredConstField() async {
+    await assertDiagnostics(r'''
+class A {
+  static const AA = (1, );
+}
+''', [
+      lint(25, 2),
+    ]);
+  }
+
+  test_destructuredConstVariable() async {
+    await assertDiagnostics(r'''
+const AA = (1, );
+''', [
+      lint(6, 2),
+    ]);
+  }
+
+  test_destructuredFinalVariable() async {
+    await assertDiagnostics(r'''
+void f() {
+  final (AA, ) = (1, );
+}
+''', [
+      lint(20, 2),
+    ]);
+  }
+}
+
 @reflectiveTest
 class ConstantIdentifierNamesRecordsTest extends LintRuleTest {
   @override