Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

check declared var patterns in constant_identifier_names #3979

Merged
merged 1 commit into from
Jan 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/rules/constant_identifier_names.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class ConstantIdentifierNames extends LintRule {
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
var visitor = _Visitor(this);
registry.addDeclaredVariablePattern(this, visitor);
registry.addEnumConstantDeclaration(this, visitor);
registry.addTopLevelVariableDeclaration(this, visitor);
registry.addVariableDeclarationList(this, visitor);
Expand All @@ -81,6 +82,11 @@ class _Visitor extends SimpleAstVisitor<void> {
}
}

@override
void visitDeclaredVariablePattern(DeclaredVariablePattern node) {
checkIdentifier(node.name);
}

@override
void visitEnumConstantDeclaration(EnumConstantDeclaration node) {
checkIdentifier(node.name);
Expand Down
38 changes: 38 additions & 0 deletions test/rules/constant_identifier_names_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,47 @@ import '../rule_test_support.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(ConstantIdentifierNamesRecordsTest);
defineReflectiveTests(ConstantIdentifierNamesPatternsTest);
});
}

@reflectiveTest
class ConstantIdentifierNamesPatternsTest extends LintRuleTest {
@override
List<String> get experiments => ['patterns', 'records'];

@override
String get lintRule => 'constant_identifier_names';

test_destructuredConstField() async {
await assertDiagnostics(r'''
class A {
static const AA = (1, );
}
''', [
lint(25, 2),
]);
}

test_destructuredConstVariable() async {
await assertDiagnostics(r'''
const AA = (1, );
''', [
lint(6, 2),
]);
}

test_destructuredFinalVariable() async {
await assertDiagnostics(r'''
void f() {
final (AA, ) = (1, );
}
''', [
lint(20, 2),
]);
}
}

@reflectiveTest
class ConstantIdentifierNamesRecordsTest extends LintRuleTest {
@override
Expand Down