This repository was archived by the owner on Nov 20, 2024. It is now read-only.
IncompatibleWith validation #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Hmmmm, looks like I've got some thinking to do to make synchrony work.) |
bwilkerson
approved these changes
Dec 27, 2019
| } | ||
|
|
||
| // Process compatibility annotations. | ||
| final rulePath = File('lib/src/rules').absolute.path; |
There was a problem hiding this comment.
Alternatively, we could analyze and visit the constructor invocations in lib/src/rules.dart. That would probably find all of the lint rule class element faster (although it would miss classes that aren't registered).
There was a problem hiding this comment.
Let's discuss refining this together. I have a few other ideas but a whiteboard would make them easier.
I'll land this as a jumping off point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #1909.
/cc @bwilkerson